Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Sridhar Siricilla, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55015 )
Change subject: soc/intel/alderlake: [WIP]Set BASE Addresses for TBT DMA remapping engine
......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55015/comment/4ed593dc_61319076
PS3, Line 35: };
Instead of using raw indexes into `VtdBaseAddress` below, can we add more values here?
https://review.coreboot.org/c/coreboot/+/55015/comment/1acbab54_901bcc6e
PS3, Line 232: 0x1
nit:
`1`
https://review.coreboot.org/c/coreboot/+/55015/comment/2ebc61bf_85fbafd1
PS3, Line 235: 3
with above comment, something like VTD_TBT0, etc.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I669255065d60d73c4bea0eeb732c4114bcc447c0
Gerrit-Change-Number: 55015
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 01 Jun 2021 18:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment