Change in coreboot[master]: mb/google/zork/vilboz: Enable P sensor

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Peichao Li (Code Review)

21 Jul 2020 21 Jul '20

6:45 a.m.

Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43665 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

mb/google/zork/vilboz: Enable P sensor

BUG=b:161759253 TEST=flash the BIOS and insure firmware node will be generate under the OS.

Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7 --- M src/mainboard/google/zork/variants/vilboz/gpio.c M src/mainboard/google/zork/variants/vilboz/overridetree.cb 2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/43665/1

diff --git a/src/mainboard/google/zork/variants/vilboz/gpio.c b/src/mainboard/google/zork/variants/vilboz/gpio.c index 4d292c2..29be3ae 100644 --- a/src/mainboard/google/zork/variants/vilboz/gpio.c +++ b/src/mainboard/google/zork/variants/vilboz/gpio.c @@ -9,6 +9,8 @@ static const struct soc_amd_gpio lte_gpio_set_stage_ram[] = { /* LTE POWER ENABLE */ PAD_GPO(GPIO_32, HIGH), + /* P sensor INT */ + PAD_SCI(GPIO_40, PULL_NONE, EDGE_LOW), };

diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index 49d21d5..63d3f7d 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -111,5 +111,12 @@ register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end + chip drivers/i2c/generic + register "hid" = ""STH9324"" + register "name" = ""SEMTECH SX9324"" + register "desc" = ""SAR Proximity Sensor"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_40)" + device i2c 28 on end + end end end # chip soc/amd/picasso

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

Furquan Shaikh (Code Review)

21 Jul 21 Jul

6:52 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43665 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... PS1, Line 13: PAD_SCI Why SCI?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7 Gerrit-Change-Number: 43665 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Tue, 21 Jul 2020 04:52:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

7:15 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43665

to look at the new patch set (#2).

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

mb/google/zork/vilboz: Enable P sensor

BUG=b:161759253 TEST=flash the BIOS and insure firmware node will be generate under the OS.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/43665/2

Peichao Li (Code Review)

7:16 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43665 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... PS1, Line 13: PAD_SCI

...

Why SCI?

SCI is unnecessary, I think PULL_LOW is ok.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7 Gerrit-Change-Number: 43665 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Tue, 21 Jul 2020 05:16:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:29 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43665 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... PS1, Line 13: PAD_SCI

...

SCI is unnecessary

So, use PAD_INT?

...

I think PULL_LOW is ok.

Why PULL_LOW? This is active low signal. Is this actively driven by the P-sensor or open-drain signal? Is there an external pull-up?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7 Gerrit-Change-Number: 43665 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 05:29:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-MessageType: comment

Peichao Li (Code Review)

7:38 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43665 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... PS1, Line 13: PAD_SCI

...

...
SCI is unnecessary […]

Dear Furquan, yes active low is correct, because these is a external pull-up resistor about 2.2k, thanks a lot.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7 Gerrit-Change-Number: 43665 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 05:38:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-MessageType: comment

Peichao Li (Code Review)

7:42 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43665 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... PS1, Line 13: PAD_SCI

...

Dear Furquan, yes active low is correct, because these is a external pull-up resistor about 2. […]

Schematic like https://drive.google.com/file/d/1F00YyVT3c2dgQ-ytsK-49XxhlWgHhauf/view?usp=s...

-- To view, visit https://review.coreboot.org/c/coreboot/+/43665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7 Gerrit-Change-Number: 43665 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 05:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

19 Oct 19 Oct

5:59 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43665 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/c/coreboot/+/43665/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43665/2//COMMIT_MSG@2 PS2, Line 2: peichao.wang Peichao Wang

https://review.coreboot.org/c/coreboot/+/43665/2//COMMIT_MSG@8 PS2, Line 8: Please quickly describe what the P sensor is.

https://review.coreboot.org/c/coreboot/+/43665/2//COMMIT_MSG@10 PS2, Line 10: insure firmware node will be generate : under the OS. … ensure OS generates firmware node by looking at the DSDT (acpidump?).

https://review.coreboot.org/c/coreboot/+/43665/2//COMMIT_MSG@13 PS2, Line 13: Peichao.Wang Peichao Wang

-- To view, visit https://review.coreboot.org/c/coreboot/+/43665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7 Gerrit-Change-Number: 43665 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 19 Oct 2020 15:59:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

10 Jun 10 Jun

5:07 a.m.

New subject: [XS] Change in coreboot[master]: mb/google/zork/vilboz: Enable P sensor

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43665?usp=email )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/43665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7 Gerrit-Change-Number: 43665 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

532

days inactive

1586

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Paul Menzel (Code Review)
Peichao Li (Code Review)
Stefan Reinauer (Code Review)