Change in coreboot[master]: ec/google/chromeec: Add code for KEY_MICMUTE and KEY_KBDILLUMTOGGLE - coreboot-gerrit

31 Jul 2021


      Attention is currently required from: Tim Wawrzynczak, Scott Chao.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56710 )
Change subject: ec/google/chromeec: Add code for KEY_MICMUTE and KEY_KBDILLUMTOGGLE
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/56710/comment/1cd423c1_575b2d3f 
PS1, Line 6334: TK_KBDILLUMTOGGLE = 18,
              : 	TK_MICMUTE = 19,
The enum values here and in the EC CL do not match.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56710
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fa3e627f448265f72279704d258b2d3fe8fc17
Gerrit-Change-Number: 56710
Gerrit-PatchSet: 1
Gerrit-Owner: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Rajat Jain rajatja@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Sat, 31 Jul 2021 12:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment