Attention is currently required from: Angel Pons, David Milosevic, Maximilian Brune, Naresh Solanki, Nico Huber, Patrick Rudolph, Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79103?usp=email )
Change subject: mb/arm/rdn2: Add support for Arm Neoverse N2
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/mainboard/arm/rdn2/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79103/comment/b023c72b_133b6b7f :
PS3, Line 15: mcmodel=large
This really looks like a CFLAG and not a CPPFLAG. Also do you need to set this one at the mainboard level?
https://review.coreboot.org/c/coreboot/+/79103/comment/0768417c_67533aaf :
PS3, Line 16: CPPFLAGS_common += -mstrict-align
This is a CFLAG. Also do you need this? What data you're trying to access is unaligned?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79103?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I17908d3ce773d4a88924bafb1d0e9e2a043c7fbc
Gerrit-Change-Number: 79103
Gerrit-PatchSet: 3
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Wed, 13 Dec 2023 18:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment