Change in coreboot[master]: asus/p2b-ls: Drop SCSI from devicetree

List overview All Threads
Download

newer

older

Change in coreboot[master]: [WIP]...

Change in coreboot[master]:...

Keith Hui (Code Review)

27 Jan 2020 27 Jan '20

6:24 p.m.

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38602 )

Change subject: asus/p2b-ls: Drop SCSI from devicetree ......................................................................

asus/p2b-ls: Drop SCSI from devicetree

SCSI bus on this board does not need any special treatment facilitated by devicetree.cb.

Change-Id: I5ee9cd605bf4c22561f826945be1374fd8257c82 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b-ls/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/38602/1

diff --git a/src/mainboard/asus/p2b-ls/devicetree.cb b/src/mainboard/asus/p2b-ls/devicetree.cb index 5e55278..9a5f278 100644 --- a/src/mainboard/asus/p2b-ls/devicetree.cb +++ b/src/mainboard/asus/p2b-ls/devicetree.cb @@ -48,7 +48,6 @@ device pci 4.1 on end # IDE device pci 4.2 on end # USB device pci 4.3 on end # ACPI - device pci 6.0 on end # Onboard SCSI register "ide0_enable" = "1" register "ide1_enable" = "1" register "ide_legacy_enable" = "1"

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Paul Menzel (Code Review)

28 Jan 28 Jan

4:55 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38602 )

Change subject: asus/p2b-ls: Drop SCSI from devicetree ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d... PS1, Line 51: device pci 6.0 on end # Onboard SCSI Isn’t it common in coreboot to list all on-board devices nevertheless?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ee9cd605bf4c22561f826945be1374fd8257c82 Gerrit-Change-Number: 38602 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jan 2020 12:55:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

2 Feb 2 Feb

4:28 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38602 )

Change subject: asus/p2b-ls: Drop SCSI from devicetree ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d... PS1, Line 51: device pci 6.0 on end # Onboard SCSI

...

Isn’t it common in coreboot to list all on-board devices nevertheless?

I'd prefer if the device was kept here, so that it helps document the mainboard.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ee9cd605bf4c22561f826945be1374fd8257c82 Gerrit-Change-Number: 38602 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 02 Feb 2020 12:28:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Keith Hui (Code Review)

9:45 a.m.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38602 )

Change subject: asus/p2b-ls: Drop SCSI from devicetree ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d... PS1, Line 51: device pci 6.0 on end # Onboard SCSI

...

I'd prefer if the device was kept here, so that it helps document the mainboard.

I'd prefer to keep it commented out, as the entry adds code to ramstage. With only 256KiB flash every byte counts.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ee9cd605bf4c22561f826945be1374fd8257c82 Gerrit-Change-Number: 38602 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 02 Feb 2020 17:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Keith Hui (Code Review)

27 Mar 27 Mar

4:33 p.m.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38602 )

Change subject: asus/p2b-ls: Drop SCSI from devicetree ......................................................................

Patch Set 1:

This devicetree.cb once had an entry for LAN too, which was dropped long ago (by me too), and with no ill effect. These two devices can be documented elsewhere, and if those documentation(s) are lacking, I can improve on them.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ee9cd605bf4c22561f826945be1374fd8257c82 Gerrit-Change-Number: 38602 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 27 Mar 2020 23:33:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Keith Hui (Code Review)

4:40 p.m.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38602 )

Change subject: asus/p2b-ls: Drop SCSI from devicetree ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d... PS1, Line 51: device pci 6.0 on end # Onboard SCSI

...

I'd prefer to keep it commented out, as the entry adds code to ramstage. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ee9cd605bf4c22561f826945be1374fd8257c82 Gerrit-Change-Number: 38602 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 27 Mar 2020 23:40:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Keith Hui buurin@gmail.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

28 Mar 28 Mar

12:01 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38602 )

Change subject: asus/p2b-ls: Drop SCSI from devicetree ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38602/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38602/1//COMMIT_MSG@11 PS1, Line 11: Please update the commit message, how many bytes this saves.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ee9cd605bf4c22561f826945be1374fd8257c82 Gerrit-Change-Number: 38602 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 28 Mar 2020 07:01:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Keith Hui (Code Review)

9:01 p.m.

Keith Hui has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38602 )

Change subject: asus/p2b-ls: Drop SCSI from devicetree ......................................................................

Abandoned

Hold till conversion to variant is complete.

1694

days inactive

1755

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Keith Hui (Code Review)
Paul Menzel (Code Review)