Attention is currently required from: Eran Mitrani, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Subrata Banik, Tarun.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78387?usp=email )
Change subject: soc/intel/{adl, mtl}: Avoid redundant display init by joining to MBUS
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/78387/comment/b45b6d2f_c4c8e798 :
PS1, Line 92: BMP_LOGO
oh I mean maybe we don't need the guard? If we don't have boot logo, it will skip the panel init, […]
oh probably add display init check in the .final in last patch? If not init then skip.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78387?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36af167afa902053a987602d494a8830ad9b1b1a
Gerrit-Change-Number: 78387
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paz Zcharya
pazz@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paz Zcharya
pazz@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 16 Oct 2023 17:04:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment