Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Varshit Pandya.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81627?usp=email )
Change subject: mb/google/brya: Create trulo variant ......................................................................
Patch Set 13:
(4 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81627/comment/8ac4b779_b8a9636e : PS10, Line 498: select BOARD_GOOGLE_BASEBOARD_TRULO
select SOC_INTEL_TWINLAKE
Acknowledged
File src/mainboard/google/brya/variants/trulo/memory/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81627/comment/da2daf59_6e45bbae : PS10, Line 7: SPD_SOURCES += spd/lp5/set-0/spd-2.hex # ID = 0(0b0000) Parts = MT62F1G32D4DR-031 WT:B : SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 1(0b0001) Parts = MT62F512M32D2DR-031 WT:B
empty
Acknowledged
File src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/81627/comment/8b862d43_d5661c59 : PS10, Line 7: MT62F1G32D4DR-031 WT:B 0 (0000) : MT62F512M32D2DR-031 WT:B 1 (0001)
should be empty
Acknowledged
File src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/81627/comment/6ec3a18d_a6b8aaf2 : PS10, Line 12: MT62F1G32D4DR-031 WT:B : MT62F512M32D2DR-031 WT:B
empty
Acknowledged