Attention is currently required from: Jason Glenesk, Matt DeVillier, Julius Werner, Fred Reitberger, Yu-Ping Wu, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70382 )
Change subject: soc/amd/common/psp_verstage: Report previous boot status
......................................................................
Patch Set 8:
(2 comments)
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/70382/comment/db5c0f5c_4b17a334
PS7, Line 143: svc_get_prev_boot_status(&boot_status);
I'm not familiar with SVC commands, but do we need to check the return value here?
I am not expecting the SVC call to fail. Still I handled it as if the previous boot failed. Ignoring the SVC call failure might cause the system to boot loop.
https://review.coreboot.org/c/coreboot/+/70382/comment/4d03dc1d_fde73d4d
PS7, Line 148: Error in previous boot
This seems a bit too general. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iada0ec7c373db75765ba42cb531b16c2236b6cc3
Gerrit-Change-Number: 70382
Gerrit-PatchSet: 8
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 14 Dec 2022 21:25:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment