Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/47354
to review the following change.
Change subject: mb/google/volteer: Add variant_devtree_update ......................................................................
mb/google/volteer: Add variant_devtree_update
Add variant_devtree_update() to override devicetree setting.
BUG=none BRANCH=volteer TEST=emerge-volteer coreboot
Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com Change-Id: Ida87617669e6c843b48427e87e9bb154a5df7d9e --- M src/mainboard/google/volteer/mainboard.c M src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h 2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/47354/1
diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c index acba972..77f9f57 100644 --- a/src/mainboard/google/volteer/mainboard.c +++ b/src/mainboard/google/volteer/mainboard.c @@ -64,6 +64,11 @@ } }
+void __weak variant_devtree_update(void) +{ + /* Override dev tree settings per board */ +} + static void mainboard_init(struct device *dev) { mainboard_ec_init(); @@ -114,6 +119,7 @@ cfg->gpio_override_pm = 1; memset(cfg->gpio_pm, 0, sizeof(cfg->gpio_pm)); } + variant_devtree_update(); }
static void mainboard_chip_init(void *chip_info) diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h index 8408198..4d5dc87 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h @@ -21,4 +21,7 @@ const struct ddr_memory_cfg *variant_memory_params(void); int variant_memory_sku(void);
+/* Modify devictree settings during ramstage. */ +void variant_devtree_update(void); + #endif /* __BASEBOARD_VARIANTS_H__ */
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47354?usp=email )
Change subject: mb/google/volteer: Add variant_devtree_update ......................................................................
Abandoned