Attention is currently required from: Bao Zheng, Raul Rangel, Martin Roth, Tim Van Patten, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74950 )
Change subject: util/amdfwtool: Consolidate entry line regex pattern ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
Can you verify the SHAs?
SHA is changing because the compressed bootblock (Type 0x62 entry) keeps changing before and after this change. I am trying to figure out why.
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/74950/comment/499b10fe_561f21b9 PS1, Line 651: 3
`OPT_LEVEL` = 4 now, meaning the index has changed. […]
Nothing outside this file uses/rely on it. Again this is added for clarity.
https://review.coreboot.org/c/coreboot/+/74950/comment/f2ee5154_994066bb PS1, Line 56: OPT_SPACE1,
This value is shifting `OPT_LEVEL` from `3` to `4`. It's also never used. […]
If you look at the regex pattern capture group, a new group got introduced as part of consolidation.
Optional level field also includes an optional whitespace separator. OPT_SPACE1 is not used, but defined for clarity.
-
Karthik Ramasubramanian (Code Review)