Attention is currently required from: David Hendricks, Paul Menzel, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, Felix Held.
Mariusz Szafrański has uploaded a new patch set (#3) to the change originally created by King Sumo. ( https://review.coreboot.org/c/coreboot/+/57033 )
Change subject: soc/intel/denverton_ns: Add early SPI flash init
......................................................................
soc/intel/denverton_ns: Add early SPI flash init
This change follows other Intel SoCs and adds early SPI flash init
in bootblock to allow SPI flash access in earlier stages.
This also fixes MRC cache write issue mentioned below.
Fast SPI initialization is required for MRC cache write. Due to the
missing initialization, the SPI transaction causes the assertion of the
FCERR error bit (BIOS_HSFSTS_CTL register), so the Flash writes are
failing.
(Takenover on author request)
Link: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/W2E7G...
Change-Id: I50cc4f8ced0b0524b39eece5a2bb4f0d99fb4eff
Signed-off-by: Mariusz Szafranski mariuszx.szafranski@intel.com
---
M src/soc/intel/denverton_ns/bootblock/bootblock.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/57033/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50cc4f8ced0b0524b39eece5a2bb4f0d99fb4eff
Gerrit-Change-Number: 57033
Gerrit-PatchSet: 3
Gerrit-Owner: King Sumo
kingsumos@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: King Sumo
kingsumos@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Name of user not set #1001763
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset