Attention is currently required from: Felix Friedlander, Martin Roth, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49233 )
Change subject: payloads/external/tianocore/Kconfig: elaborate help for TIANOCORE_BOOTSPLASH_FILE ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49233/comment/1764cafe_0aecb8b4 PS1, Line 7: payloads/external/tianocore/Kconfig: elaborate help for TIANOCORE_BOOTSPLASH_FILE The prefix does not need to be the path (often it can be used though). Some suggestions:
1. payloads/tianocore/Kconfig: Extend help for bootsplash file 2. tianocore: Extend Kconfig help for bootsplash file 3. payloads/tianocore/Kconfig: Add detail on how bootsplash is used in OS
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/49233/comment/ae76ac5a_3111c1bd PS1, Line 100: and will be displayed slightly above the centre of : the screen, I do not understand this. Do you mean, a log should be placed above the centre of the screen so the OS spinner and text does not overlay with it?
https://review.coreboot.org/c/coreboot/+/49233/comment/9f607acd_d1914788 PS1, Line 102: than your display. If you have it handy, it’d be great if you put the URL to the specification here too.