Change in coreboot[master]: WIP:src/amd/common: Detect SOC type before access SPI 0x2C

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Bao Zheng (Code Review)

28 Dec 2020 28 Dec '20

3:38 p.m.

Hello Zheng Bao,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48955

to review the following change.

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

WIP:src/amd/common: Detect SOC type before access SPI 0x2C

Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/spi/fch_spi.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48955/1

diff --git a/src/soc/amd/common/block/spi/fch_spi.c b/src/soc/amd/common/block/spi/fch_spi.c index c39147a..910521a 100644 --- a/src/soc/amd/common/block/spi/fch_spi.c +++ b/src/soc/amd/common/block/spi/fch_spi.c @@ -60,6 +60,7 @@ { lpc_enable_spi_rom(SPI_ROM_ENABLE); lpc_enable_spi_prefetch(); - fch_spi_disable_4dw_burst(); + if (!CONFIG(SOC_AMD_CEZANNE)) + fch_spi_disable_4dw_burst(); fch_spi_config_modes(); }

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Bao Zheng (Code Review)

20 Jan 20 Jan

10:49 a.m.

Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48955

to look at the new patch set (#13).

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

WIP:src/amd/common: Detect SOC type before access SPI 0x2C

Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/spi/fch_spi.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48955/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/48955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Gerrit-Change-Number: 48955 Gerrit-PatchSet: 13 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bao Zheng (Code Review)

12:13 p.m.

Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48955

to look at the new patch set (#14).

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

WIP:src/amd/common: Detect SOC type before access SPI 0x2C

Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/spi/fch_spi.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48955/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/48955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Gerrit-Change-Number: 48955 Gerrit-PatchSet: 14 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bao Zheng (Code Review)

7:17 p.m.

Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48955

to look at the new patch set (#16).

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

WIP:src/amd/common: Detect SOC type before access SPI 0x2C

Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/spi/fch_spi.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48955/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/48955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Gerrit-Change-Number: 48955 Gerrit-PatchSet: 16 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bao Zheng (Code Review)

23 Jan 23 Jan

4:43 a.m.

Attention is currently required from: Bao Zheng. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48955

to look at the new patch set (#35).

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

WIP:src/amd/common: Detect SOC type before access SPI 0x2C

Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/spi/fch_spi.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48955/35

-- To view, visit https://review.coreboot.org/c/coreboot/+/48955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Gerrit-Change-Number: 48955 Gerrit-PatchSet: 35 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Bao Zheng fishbaozi@gmail.com Gerrit-MessageType: newpatchset

Bao Zheng (Code Review)

5:57 a.m.

Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48955

to look at the new patch set (#36).

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

WIP:src/amd/common: Detect SOC type before access SPI 0x2C

Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/spi/fch_spi.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48955/36

-- To view, visit https://review.coreboot.org/c/coreboot/+/48955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Gerrit-Change-Number: 48955 Gerrit-PatchSet: 36 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Martin Roth (Code Review)

25 Jan 25 Jan

10:59 p.m.

Attention is currently required from: Bao Zheng. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48955 )

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

Patch Set 37:

(1 comment)

File src/soc/amd/common/block/spi/fch_spi.c:

https://review.coreboot.org/c/coreboot/+/48955/comment/896e316b_c9919fe8 PS37, Line 63: CONFIG(SOC_AMD_CEZANNE) This certainly works, but as we add more chips, we'll need to keep updating it. What about checking the family of the chip and only enabling it if the chip is fam17h or earlier?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Gerrit-Change-Number: 48955 Gerrit-PatchSet: 37 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Bao Zheng fishbaozi@gmail.com Gerrit-Comment-Date: Mon, 25 Jan 2021 20:59:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Bao Zheng (Code Review)

27 Jan 27 Jan

5:21 a.m.

Attention is currently required from: Raul Rangel. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48955

to look at the new patch set (#39).

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

WIP:src/amd/common: Detect SOC type before access SPI 0x2C

Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/spi/fch_spi.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48955/39

-- To view, visit https://review.coreboot.org/c/coreboot/+/48955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Gerrit-Change-Number: 48955 Gerrit-PatchSet: 39 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Raul Rangel rrangel@chromium.org Gerrit-MessageType: newpatchset

Martin L Roth (Code Review)

7 Aug 7 Aug

11:13 p.m.

New subject: [XS] Change in coreboot[master]: WIP:src/amd/common: Detect SOC type before access SPI 0x2C

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48955?usp=email )

Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169 Gerrit-Change-Number: 48955 Gerrit-PatchSet: 42 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

546

days inactive

1498

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Bao Zheng (Code Review)
Martin L Roth (Code Review)
Martin Roth (Code Review)