Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29669 )
Change subject: cpu/intel/sandybridge: Add `hyper_threading` option
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/29669/2/src/cpu/intel/model_206ax/bootblock....
File src/cpu/intel/model_206ax/bootblock.c:
https://review.coreboot.org/#/c/29669/2/src/cpu/intel/model_206ax/bootblock....
PS2, Line 126: /* Set current requests */
: RCBA32(SOFT_RESET_DATA) = soft_reset;
: /* Use them instead of defaults */
: RCBA32_OR(SOFT_RESET_CTRL, 1);
move into `if`?
https://review.coreboot.org/#/c/29669/2/src/cpu/intel/model_206ax/bootblock....
PS2, Line 132: outb(0x2, 0xcf9);
: outb(0x6, 0xcf9);
: halt();
use system_reset()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b73e32ff5af8ea64a47e8aa706e27648aaf0993
Gerrit-Change-Number: 29669
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Comment-Date: Wed, 15 May 2019 10:00:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment