Attention is currently required from: Shelley Chen, Venkat Thogaru, Julius Werner, Yu-Ping Wu.
Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66975 )
Change subject: qualcomm/sc7280: remove unnecessary malloc and early return on failure
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66975/comment/3fe1d43b_0dd8b25f
PS2, Line 6:
Possible long commit subject (prefer a maximum 65 characters) […]
Done
https://review.coreboot.org/c/coreboot/+/66975/comment/37a8e30f_58a6b88e
PS2, Line 9: priniting
printing
Done
https://review.coreboot.org/c/coreboot/+/66975/comment/ae142daf_c382d6b7
PS2, Line 11: static
It's not a static variable, just a local variable.
Done
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
https://review.coreboot.org/c/coreboot/+/66975/comment/3204d637_f8496ef5
PS2, Line 1225: tu_table
Align with BIOS_INFO.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66975
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51f7a86d143128d2c426fb8940ff34a66152b426
Gerrit-Change-Number: 66975
Gerrit-PatchSet: 3
Gerrit-Owner: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 05 Sep 2022 10:52:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment