Attention is currently required from: Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54036 )
Change subject: soc/intel/alderlake: Update meminit code due to upd changes FSP 2147 onwards
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54036/comment/06a9e5ff_ac294d0f
PS1, Line 7: WIP
Thanks Furquan, I will fix these.
Done
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/54036/comment/041774c9_50bf6172
PS1, Line 135: disable_dimm_upds
This should be renamed to `disable_channel_upds` and the pointers need update too.
Done
https://review.coreboot.org/c/coreboot/+/54036/comment/b9a5b3fb_98259325
PS1, Line 136: DisableDimmMc0Ch0
Should be replaced by DisableMc0Ch0, right?
I was expecting another patch to take care of that. Done now.
https://review.coreboot.org/c/coreboot/+/54036/comment/82bea405_e8b0abdd
PS1, Line 164:
nit: Instead of disabling all channels individually above, you can use a flag here: […]
Done
https://review.coreboot.org/c/coreboot/+/54036/comment/75fe72e8_fbff309e
PS1, Line 168: break;
This is wrong. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54036
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5af11ae99db3bbe3373a9bd4ce36453b58d62fec
Gerrit-Change-Number: 54036
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 12 May 2021 23:06:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Selma Bensaid
selma.bensaid@intel.com
Gerrit-MessageType: comment