Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner, Arthur Heymans.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59194 )
Change subject: src/lib: Added CBMEM tag id to parse ddr information
......................................................................
Patch Set 18:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59194/comment/079cee46_839211ca
PS16, Line 9: BUG=b:182963902
Please add Bug id 177917361, to BUG=
Done
File src/commonlib/include/commonlib/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/59194/comment/5639c557_45b960b6
PS5, Line 82: 0x10
Well, it's an emergent pattern more than a rule... […]
Done
https://review.coreboot.org/c/coreboot/+/59194/comment/3f208b24_5ae80d74
PS5, Line 152:
no extra space
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/59194/comment/2cdad2cf_bcdd533e
PS5, Line 88: /* The following options are CMOS-related */
Your entry is not CMOS-related so it should be added above here (as 0x0043). […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I594bd9266a6379e3a85de507eaf4c56619b17a6f
Gerrit-Change-Number: 59194
Gerrit-PatchSet: 18
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: mturney mturney
quic_mturney@quicinc.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: mturney mturney
quic_mturney@quicinc.com
Gerrit-Comment-Date: Tue, 01 Feb 2022 09:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment