HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44134 )
Change subject: include/device/azalia_device.h: Include <stdint.h> ......................................................................
include/device/azalia_device.h: Include <stdint.h>
This file is using anly <stdint.h>. So replace <types.h> with <stdint.h>.
Change-Id: Ib58532837941d5324b28bc2c607d70555ce9caee Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/azalia_device.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/44134/1
diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h index 9026091..fe23c70 100644 --- a/src/include/device/azalia_device.h +++ b/src/include/device/azalia_device.h @@ -3,10 +3,10 @@ #ifndef DEVICE_AZALIA_H #define DEVICE_AZALIA_H
-#include <types.h> #include <acpi/acpi.h> #include <device/mmio.h> #include <device/device.h> +#include <stdint.h>
void azalia_audio_init(struct device *dev); extern struct device_operations default_azalia_audio_ops;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44134 )
Change subject: include/device/azalia_device.h: Include <stdint.h> ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44134/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44134/1//COMMIT_MSG@9 PS1, Line 9: is using anly only needs
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44134
to look at the new patch set (#2).
Change subject: include/device/azalia_device.h: Include <stdint.h> ......................................................................
include/device/azalia_device.h: Include <stdint.h>
This file only needs <stdint.h>. So replace <types.h> with <stdint.h>.
Change-Id: Ib58532837941d5324b28bc2c607d70555ce9caee Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/azalia_device.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/44134/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44134 )
Change subject: include/device/azalia_device.h: Include <stdint.h> ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44134/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44134/1//COMMIT_MSG@9 PS1, Line 9: is using anly
only needs
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44134 )
Change subject: include/device/azalia_device.h: Include <stdint.h> ......................................................................
include/device/azalia_device.h: Include <stdint.h>
This file only needs <stdint.h>. So replace <types.h> with <stdint.h>.
Change-Id: Ib58532837941d5324b28bc2c607d70555ce9caee Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44134 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/azalia_device.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h index 9026091..fe23c70 100644 --- a/src/include/device/azalia_device.h +++ b/src/include/device/azalia_device.h @@ -3,10 +3,10 @@ #ifndef DEVICE_AZALIA_H #define DEVICE_AZALIA_H
-#include <types.h> #include <acpi/acpi.h> #include <device/mmio.h> #include <device/device.h> +#include <stdint.h>
void azalia_audio_init(struct device *dev); extern struct device_operations default_azalia_audio_ops;
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)