Hello Maccraft123,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40318
to review the following change.
Change subject: mb/qemu-q35: Select `HAVE_CMOS_DEFAULT` ......................................................................
mb/qemu-q35: Select `HAVE_CMOS_DEFAULT`
Change-Id: If4c4dc9467154a18168550538fc8e655636e87a0 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/emulation/qemu-q35/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/40318/1
diff --git a/src/mainboard/emulation/qemu-q35/Kconfig b/src/mainboard/emulation/qemu-q35/Kconfig index 31aa3d8..6a0903d 100644 --- a/src/mainboard/emulation/qemu-q35/Kconfig +++ b/src/mainboard/emulation/qemu-q35/Kconfig @@ -5,6 +5,7 @@ select CPU_QEMU_X86 select SOUTHBRIDGE_INTEL_I82801IX select IOAPIC_INTERRUPTS_ON_APIC_SERIAL_BUS + select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE # select HAVE_PIRQ_TABLE select HAVE_ACPI_TABLES
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40318 )
Change subject: mb/qemu-q35: Select `HAVE_CMOS_DEFAULT` ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40318 )
Change subject: mb/qemu-q35: Select `HAVE_CMOS_DEFAULT` ......................................................................
mb/qemu-q35: Select `HAVE_CMOS_DEFAULT`
Change-Id: If4c4dc9467154a18168550538fc8e655636e87a0 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40318 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/emulation/qemu-q35/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/emulation/qemu-q35/Kconfig b/src/mainboard/emulation/qemu-q35/Kconfig index 31aa3d8..6a0903d 100644 --- a/src/mainboard/emulation/qemu-q35/Kconfig +++ b/src/mainboard/emulation/qemu-q35/Kconfig @@ -5,6 +5,7 @@ select CPU_QEMU_X86 select SOUTHBRIDGE_INTEL_I82801IX select IOAPIC_INTERRUPTS_ON_APIC_SERIAL_BUS + select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE # select HAVE_PIRQ_TABLE select HAVE_ACPI_TABLES
-
Angel Pons (Code Review) -
Nico Huber (Code Review)