Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 70:
(5 comments)
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 74: Touch Pad
touch pad? this isn't a laptop. […]
Done
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 95: M.2 WWAN
also likely incorrect comment
Done
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 236: device pnp 2e.0 on
Yes, it will generate the container ACPI code
please add a comment to this line to make clear what it does
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 265: 6
at least that's what legacy machines used for that port. […]
Done
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 269: 5
IRQ 5 was used for the second and third parallel port and sound cards
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 70
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Keno Fischer
keno@alumni.harvard.edu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: T. Hudson
trammell.hudson@gmail.com
Gerrit-Reviewer: Trammell Hudson
hudson@trmm.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 19 Aug 2019 03:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment