Attention is currently required from: Stefan Reinauer, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80235?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/ifdtool: Add new cmdline to enable GPR0 protection ......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80235/comment/a76ef596_4fe370bf : PS5, Line 7: Add new cmdline to enable GPR0 protection Maybe:
Add new switch -E to protect GPR0
https://review.coreboot.org/c/coreboot/+/80235/comment/6cdce12c_c803d389 : PS5, Line 9: IFD Tool I have not seen that spelling – only ifdtool.
https://review.coreboot.org/c/coreboot/+/80235/comment/2dd6bc72_7a0ae47e : PS5, Line 11: Additionally, perform some code refactoring while adding support It’d be great, if you added a blank line between paragraphs.
https://review.coreboot.org/c/coreboot/+/80235/comment/acbdf667_49bf2100 : PS5, Line 13: Can you point to a document, where more information about GPR0 protection can be found?