Attention is currently required from: Raul Rangel, Martin L Roth, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64547 )
Change subject: Makefile.inc: Add bootblock to CBFS before others
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64547/comment/47913b72_b23fd80f
PS2, Line 9: cbfstool
The metadata hash is _in_ the bootblock, so if there is no bootblock there can be no metadata hash. […]
Ack
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/64547/comment/cf28c4cc_a1c84c7a
PS2, Line 1109: $(CBFSTOOL) $@.tmp create -M $(obj)/fmap.fmap -r $(shell cat $(obj)/fmap.desc)
Rather than creating a lot more rules, can't we just stick the bootblock creation in here? It doesn' […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I385deb8231e44310ee139c3f69f449e75b92b2be
Gerrit-Change-Number: 64547
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@tutanota.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@tutanota.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 26 May 2022 01:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment
Yu-Ping Wu (Code Review)