Change in ...coreboot[master]: mb/emulation/qemu-q35: Add x86_64 support - coreboot-gerrit

1 Mar 2019


      Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29667 )
Change subject: mb/emulation/qemu-q35: Add x86_64 support
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/#/c/29667/15/src/mainboard/emulation/qemu-q35/ro... 
File src/mainboard/emulation/qemu-q35/romstage.c:
https://review.coreboot.org/#/c/29667/15/src/mainboard/emulation/qemu-q35/ro... 
PS15, Line 48: 	 * configure MTRRs here as on real hardware.
I don't see the connection in requiring MTRRs to be setup to be able to use page-tables.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2f02a95b2f91ab51043d4e81054354f4a6eb5d5
Gerrit-Change-Number: 29667
Gerrit-PatchSet: 15
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Mar 2019 03:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment