Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Reka Norman, Tyler Wang, Peter Ou.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 )
Change subject: mb/google/nissa/var/craask: Modify DPTF settings
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
Can you please add your test results on bug with these changes? This will help us to review this patch. Thanks.
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71860/comment/2faec356_51c3a5e4
PS5, Line 230: Fan
I don't see ACTIVE policy table with Temperature trip points and fan speed control for thermal sensors.
Only adding this entries from line 230 to 246 will not help to control fan using active policy. You need to add active policy table as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd
Gerrit-Change-Number: 71860
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 09:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment