Change in coreboot[master]: util/apcb/apcb_v3_edit.py: Edit APCB based on different SPD magic - coreboot-gerrit

13 Apr 2022


      Attention is currently required from: Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63598 )
Change subject: util/apcb/apcb_v3_edit.py: Edit APCB based on different SPD magic
......................................................................
Patch Set 1:
(1 comment)
File util/apcb/apcb_v3_edit.py:
https://review.coreboot.org/c/coreboot/+/63598/comment/1a1a464c_a5664194 
PS1, Line 51:         '--spd_magic',
How about adding a --memory_type [lp4 | lp5] argument? Then we can keep the SPD magic numbers defined here.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63598
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e96c89e4e5ce8e0567a17bf7685b69080fa1708
Gerrit-Change-Number: 63598
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Robert Zieba robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 18:20:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment