Attention is currently required from: Tim Wawrzynczak, Paul Menzel.
Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63792 )
Change subject: ec/google/chromeec: Add EC Mux device
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Sure. Which config would be apropriate? `configs/config.google_volteer.build_test_purposes` ? […]
OK. Just to clarify, if I add the devices to the override.cb then I *dont* need to select the Kconfig?
File src/ec/google/chromeec/mux/Kconfig:
https://review.coreboot.org/c/coreboot/+/63792/comment/933a8884_b3f17ed5
PS1, Line 8: which is used
I also marked *which*. It’s a contact clause [1]. Anyway, feel free to improve or leave as is. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2022810292783583ee5f09ce29a63b96686dbb8
Gerrit-Change-Number: 63792
Gerrit-PatchSet: 1
Gerrit-Owner: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 02 May 2022 18:31:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Prashant Malani
pmalani@chromium.org
Gerrit-MessageType: comment