HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37888 )
Change subject: src: Remove unused include <string.h> ......................................................................
src: Remove unused include <string.h>
Change-Id: Ic6b66dd8fa387e67bb0ce609fb7e2553eeb66b3c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/ebda.c M src/drivers/generic/gfx/gfx.c M src/lib/hexdump.c M src/lib/hexstrtobin.c M src/security/vboot/common.c M src/soc/intel/baytrail/acpi.c M src/soc/intel/skylake/bootblock/report_platform.c M src/soc/qualcomm/sc7180/aop_load_reset.c 8 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37888/1
diff --git a/src/arch/x86/ebda.c b/src/arch/x86/ebda.c index f2727bb..f92f305 100644 --- a/src/arch/x86/ebda.c +++ b/src/arch/x86/ebda.c @@ -13,7 +13,6 @@ */
#include <stdint.h> -#include <string.h> #include <arch/acpi.h> #include <arch/ebda.h> #include <commonlib/endian.h> diff --git a/src/drivers/generic/gfx/gfx.c b/src/drivers/generic/gfx/gfx.c index 76d311c..b2bda4a 100644 --- a/src/drivers/generic/gfx/gfx.c +++ b/src/drivers/generic/gfx/gfx.c @@ -19,7 +19,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <stdint.h> -#include <string.h>
#include "chip.h"
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c index 2c9e483..8ecba6d 100644 --- a/src/lib/hexdump.c +++ b/src/lib/hexdump.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <ctype.h> #include <lib.h> -#include <string.h>
void hexdump(const void *memory, size_t length) { diff --git a/src/lib/hexstrtobin.c b/src/lib/hexstrtobin.c index 61290b8..f0d3e9d 100644 --- a/src/lib/hexstrtobin.c +++ b/src/lib/hexstrtobin.c @@ -13,7 +13,6 @@
#include <ctype.h> #include <lib.h> -#include <string.h>
size_t hexstrtobin(const char *str, uint8_t *buf, size_t len) { diff --git a/src/security/vboot/common.c b/src/security/vboot/common.c index 214f6fa..aeb4498 100644 --- a/src/security/vboot/common.c +++ b/src/security/vboot/common.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <fmap.h> #include <stdint.h> -#include <string.h> #include <symbols.h> #include <vb2_api.h> #include <security/vboot/misc.h> diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c index db6b271..77cc21b 100644 --- a/src/soc/intel/baytrail/acpi.c +++ b/src/soc/intel/baytrail/acpi.c @@ -22,7 +22,6 @@ #include <console/console.h> #include <cpu/x86/smm.h> #include <types.h> -#include <string.h> #include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <cpu/intel/turbo.h> diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c index b0b416e..4a519cf 100644 --- a/src/soc/intel/skylake/bootblock/report_platform.c +++ b/src/soc/intel/skylake/bootblock/report_platform.c @@ -27,7 +27,6 @@ #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/systemagent.h> -#include <string.h>
static struct { u32 cpuid; diff --git a/src/soc/qualcomm/sc7180/aop_load_reset.c b/src/soc/qualcomm/sc7180/aop_load_reset.c index 8d22d62..5cf2311 100644 --- a/src/soc/qualcomm/sc7180/aop_load_reset.c +++ b/src/soc/qualcomm/sc7180/aop_load_reset.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <arch/cache.h> #include <cbfs.h> #include <halt.h>
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37888 )
Change subject: src: Remove unused include <string.h> ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37888 )
Change subject: src: Remove unused include <string.h> ......................................................................
src: Remove unused include <string.h>
Change-Id: Ic6b66dd8fa387e67bb0ce609fb7e2553eeb66b3c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37888 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/arch/x86/ebda.c M src/drivers/generic/gfx/gfx.c M src/lib/hexdump.c M src/lib/hexstrtobin.c M src/security/vboot/common.c M src/soc/intel/baytrail/acpi.c M src/soc/intel/skylake/bootblock/report_platform.c M src/soc/qualcomm/sc7180/aop_load_reset.c 8 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/arch/x86/ebda.c b/src/arch/x86/ebda.c index f2727bb..f92f305 100644 --- a/src/arch/x86/ebda.c +++ b/src/arch/x86/ebda.c @@ -13,7 +13,6 @@ */
#include <stdint.h> -#include <string.h> #include <arch/acpi.h> #include <arch/ebda.h> #include <commonlib/endian.h> diff --git a/src/drivers/generic/gfx/gfx.c b/src/drivers/generic/gfx/gfx.c index 76d311c..b2bda4a 100644 --- a/src/drivers/generic/gfx/gfx.c +++ b/src/drivers/generic/gfx/gfx.c @@ -19,7 +19,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <stdint.h> -#include <string.h>
#include "chip.h"
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c index 2c9e483..8ecba6d 100644 --- a/src/lib/hexdump.c +++ b/src/lib/hexdump.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <ctype.h> #include <lib.h> -#include <string.h>
void hexdump(const void *memory, size_t length) { diff --git a/src/lib/hexstrtobin.c b/src/lib/hexstrtobin.c index 61290b8..f0d3e9d 100644 --- a/src/lib/hexstrtobin.c +++ b/src/lib/hexstrtobin.c @@ -13,7 +13,6 @@
#include <ctype.h> #include <lib.h> -#include <string.h>
size_t hexstrtobin(const char *str, uint8_t *buf, size_t len) { diff --git a/src/security/vboot/common.c b/src/security/vboot/common.c index 214f6fa..aeb4498 100644 --- a/src/security/vboot/common.c +++ b/src/security/vboot/common.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <fmap.h> #include <stdint.h> -#include <string.h> #include <symbols.h> #include <vb2_api.h> #include <security/vboot/misc.h> diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c index db6b271..77cc21b 100644 --- a/src/soc/intel/baytrail/acpi.c +++ b/src/soc/intel/baytrail/acpi.c @@ -22,7 +22,6 @@ #include <console/console.h> #include <cpu/x86/smm.h> #include <types.h> -#include <string.h> #include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <cpu/intel/turbo.h> diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c index b0b416e..4a519cf 100644 --- a/src/soc/intel/skylake/bootblock/report_platform.c +++ b/src/soc/intel/skylake/bootblock/report_platform.c @@ -27,7 +27,6 @@ #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/systemagent.h> -#include <string.h>
static struct { u32 cpuid; diff --git a/src/soc/qualcomm/sc7180/aop_load_reset.c b/src/soc/qualcomm/sc7180/aop_load_reset.c index 8d22d62..5cf2311 100644 --- a/src/soc/qualcomm/sc7180/aop_load_reset.c +++ b/src/soc/qualcomm/sc7180/aop_load_reset.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <arch/cache.h> #include <cbfs.h> #include <halt.h>
-
Aaron Durbin (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)