Attention is currently required from: char, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 )
Change subject: superio/ite: Add support for ITE IT8987e ......................................................................
Patch Set 6:
(2 comments)
File src/superio/ite/it8987e/superio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169936): https://review.coreboot.org/c/coreboot/+/72827/comment/698a74de_6eaef0a9 PS6, Line 18: if (!dev->enabled) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169936): https://review.coreboot.org/c/coreboot/+/72827/comment/aa3fc0c8_22ebd76b PS6, Line 72: } else { suspect code indent for conditional statements (8, 24)