Attention is currently required from: Jeff Daly, Fabio Aiuto, Mariusz Szafrański, Suresh Bellampalli, Stefan Reinauer, Vanessa Eusebio.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68102 )
Change subject: treewide: use helpers to check for enabled pci devices
......................................................................
Patch Set 2: -Code-Review
(1 comment)
File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/68102/comment/0682d4b6_717d2dff
PS2, Line 123: if (!is_enabled_pci(irq_dev))
This is equivalent to:
irq_dev->bus->dev->path.type != DEVICE_PATH_PCI || irq_dev->bus->secondary != 0
Whereas the original was:
irq_dev->path.type != DEVICE_PATH_PCI || irq_dev->bus->secondary != 0
Why involve the bus?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb992904112db611119b2d33c8b1dd912b2c8539
Gerrit-Change-Number: 68102
Gerrit-PatchSet: 2
Gerrit-Owner: Fabio Aiuto
fabioaiuto83@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Fabio Aiuto
fabioaiuto83@gmail.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Comment-Date: Tue, 04 Oct 2022 16:27:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment