Change in coreboot[master]: sc7280: enable bl31

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ravi kumar (Code Review)

24 Nov 2020 24 Nov '20

10:50 a.m.

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 ......................................................................

sc7280: enable bl31

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/memlayout.ld 2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/1

diff --git a/src/soc/qualcomm/sc7280/Kconfig b/src/soc/qualcomm/sc7280/Kconfig index d6f56ba..6882457 100644 --- a/src/soc/qualcomm/sc7280/Kconfig +++ b/src/soc/qualcomm/sc7280/Kconfig @@ -6,6 +6,7 @@ select ARCH_RAMSTAGE_ARMV8_64 select ARCH_ROMSTAGE_ARMV8_64 select ARCH_VERSTAGE_ARMV8_64 + select ARM64_USE_ARM_TRUSTED_FIRMWARE select GENERIC_GPIO_LIB select GENERIC_UDELAY select HAVE_MONOTONIC_TIMER diff --git a/src/soc/qualcomm/sc7280/memlayout.ld b/src/soc/qualcomm/sc7280/memlayout.ld index a3a785e..fed3a72 100644 --- a/src/soc/qualcomm/sc7280/memlayout.ld +++ b/src/soc/qualcomm/sc7280/memlayout.ld @@ -50,7 +50,7 @@ /* Various hardware/software subsystems make use of this area */ REGION(dram_aop, 0x80800000, 0x040000, 0x1000) REGION(dram_soc, 0x80900000, 0x200000, 0x1000) - BL31(0x80B00000, 1M) POSTRAM_CBFS_CACHE(0x9F800000, 16M) RAMSTAGE(0xA0800000, 16M) + BL31(0xC0000000, 1M) }

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Ravi kumar (Code Review)

18 Mar 18 Mar

2:08 p.m.

Hello build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#11).

Change subject: sc7280: enable bl31 ......................................................................

sc7280: enable bl31

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/11

Ravi kumar (Code Review)

2:25 p.m.

Hello build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#12).

Change subject: sc7280: enable bl31 ......................................................................

sc7280: enable bl31

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/12

Ravi kumar (Code Review)

31 Mar 31 Mar

5:42 a.m.

Attention is currently required from: Shelley Chen. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#27).

Change subject: sc7280: enable bl31 ......................................................................

sc7280: enable bl31

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/27

Ravi kumar (Code Review)

26 Apr 26 Apr

1:12 a.m.

Attention is currently required from: Ravi kumar, Shelley Chen. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#31).

Change subject: sc7280: enable bl31 ......................................................................

sc7280: enable bl31

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/31

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 31 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

7 May 7 May

9 p.m.

Attention is currently required from: Ravi kumar, Shelley Chen. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 ......................................................................

Patch Set 34:

(1 comment)

File src/soc/qualcomm/sc7280/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/47904/comment/e0880bc9_5b2b09af PS34, Line 46: 0x1485BC00,8K BTW we're finding out on other boards right now that 8K here seems to often not be enough. Probably a good idea to bump it to 16K right away (in a separate patch) to avoid having to find out we need to do it in crunch time later.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 34 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Comment-Date: Fri, 07 May 2021 21:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ravi kumar (Code Review)

16 Jun 16 Jun

7:49 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#48).

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld 3 files changed, 22 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/48

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 48 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

29 Jun 29 Jun

2:27 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#51).

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld 3 files changed, 23 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/51

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 51 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-MessageType: newpatchset

Ravi Kumar Bokka (Code Review)

2 Jul 2 Jul

3:33 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

Patch Set 52:

(1 comment)

File src/soc/qualcomm/sc7280/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/47904/comment/8695a0bc_dd9ffc8e PS34, Line 46: 0x1485BC00,8K

...

BTW we're finding out on other boards right now that 8K here seems to often not be enough. […]

Thank you Julius we will update the memory map with next push

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 52 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Fri, 02 Jul 2021 15:33:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Ravi kumar (Code Review)

5 Jul 5 Jul

6:18 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#54).

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld 3 files changed, 23 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/54

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 54 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: newpatchset

Ravi Kumar Bokka (Code Review)

10 Jul 10 Jul

8:05 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

Patch Set 55:

(1 comment)

File src/soc/qualcomm/sc7280/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/47904/comment/52e64bd2_56017dcb PS34, Line 46: 0x1485BC00,8K

...

Thank you Julius we will update the memory map with next push

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 55 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Sat, 10 Jul 2021 20:05:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Ravi kumar (Code Review)

14 Jul 14 Jul

2 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#57).

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld 3 files changed, 23 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/57

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 57 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

8 Sep 8 Sep

1:29 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, Julius Werner, mturney mturney. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#69).

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld 3 files changed, 23 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/69

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 69 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

13 Sep 13 Sep

12:18 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, Julius Werner, mturney mturney. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#70).

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld 3 files changed, 23 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/70

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 70 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

21 Sep 21 Sep

7:32 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, Julius Werner, mturney mturney. Hello Shelley Chen, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47904

to look at the new patch set (#74).

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

Developer/Reviewer, be aware of this patch from Napali: https://review.coreboot.org/c/coreboot/+/28014/44

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld 3 files changed, 23 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/74

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 74 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Shelley Chen (Code Review)

15 Oct 15 Oct

11:34 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

Patch Set 81: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 81 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-Comment-Date: Fri, 15 Oct 2021 23:34:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

18 Oct 18 Oct

6:34 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

Patch Set 82: Code-Review-1

(1 comment)

Patchset:

PS82: Looks like you have a build error that you need to resolve here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 82 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Mon, 18 Oct 2021 18:34:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

12 Jan 12 Jan

5:41 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner. Shelley Chen has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

Removed Code-Review-1 by Shelley Chen shchen@google.com

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 100 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: deleteVote

Shelley Chen (Code Review)

5:42 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

Patch Set 100:

(1 comment)

Patchset:

PS100: This looks ok, but you need to rebase so that it doesn't fail Jenkins. It's failing right now due to the previous patch.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 100 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Wed, 12 Jan 2022 17:42:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shelley Chen (Code Review)

20 Jan 20 Jan

6:06 a.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

Patch Set 102:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47904/comment/676fef25_96f53895 PS102, Line 9: Developer/Reviewer, be aware of this patch from Napali: : https://review.coreboot.org/c/coreboot/+/28014/44 : Source looks ok, but was wondering you wanted the reviewer to know about in this abandoned CL?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 102 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney quic_mturney@quicinc.com Gerrit-Comment-Date: Thu, 20 Jan 2022 06:06:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

mturney mturney (Code Review)

8:04 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. mturney mturney has uploaded a new patch set (#103) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc 2 files changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/47904/103

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 103 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney quic_mturney@quicinc.com Gerrit-MessageType: newpatchset

Shelley Chen (Code Review)

11:06 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

Patch Set 103: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47904/comment/c75d284c_40efdcf2 PS102, Line 9: Developer/Reviewer, be aware of this patch from Napali: : https://review.coreboot.org/c/coreboot/+/28014/44 :

...

Source looks ok, but was wondering you wanted the reviewer to know about in this abandoned CL?

This was removed in the latest patchset.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Gerrit-Change-Number: 47904 Gerrit-PatchSet: 103 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney quic_mturney@quicinc.com Gerrit-Comment-Date: Thu, 20 Jan 2022 23:06:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Shelley Chen shchen@google.com Gerrit-MessageType: comment

Shelley Chen (Code Review)

28 Jan 28 Jan

5:11 p.m.

New subject: Change in coreboot[master]: sc7280: enable bl31 and SDI feature support

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47904 )

Change subject: sc7280: enable bl31 and SDI feature support ......................................................................

sc7280: enable bl31 and SDI feature support

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I61c695fb4fef3ae36ffc5a263236b9d40c299dc4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47904 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Shelley Chen shchen@google.com --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc 2 files changed, 21 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved

diff --git a/src/soc/qualcomm/sc7280/Kconfig b/src/soc/qualcomm/sc7280/Kconfig index 24d5c20..68234f9 100644 --- a/src/soc/qualcomm/sc7280/Kconfig +++ b/src/soc/qualcomm/sc7280/Kconfig @@ -6,6 +6,7 @@ select ARCH_RAMSTAGE_ARMV8_64 select ARCH_ROMSTAGE_ARMV8_64 select ARCH_VERSTAGE_ARMV8_64 + select ARM64_USE_ARM_TRUSTED_FIRMWARE select GENERIC_GPIO_LIB select GENERIC_UDELAY select HAVE_MONOTONIC_TIMER diff --git a/src/soc/qualcomm/sc7280/Makefile.inc b/src/soc/qualcomm/sc7280/Makefile.inc index 6a02bdb..4c83722 100644 --- a/src/soc/qualcomm/sc7280/Makefile.inc +++ b/src/soc/qualcomm/sc7280/Makefile.inc @@ -51,6 +51,26 @@ SC7280_BLOB := $(top)/3rdparty/qc_blobs/sc7280

################################################################################ +BL31_MAKEARGS += PLAT=sc7280 + +ifeq ($(CONFIG_QC_SDI_ENABLE),y) +BL31_MAKEARGS += QTI_SDI_BUILD=1 +BL31_MAKEARGS += QTISECLIB_PATH=$(SC7280_BLOB)/qtiseclib/libqtisec_dbg.a +else +BL31_MAKEARGS += QTISECLIB_PATH=$(SC7280_BLOB)/qtiseclib/libqtisec.a +endif # CONFIG_QC_SDI_ENABLE + +################################################################################ +ifeq ($(CONFIG_QC_SDI_ENABLE),y) +QCSDI_FILE := $(SC7280_BLOB)/boot/QcSdi.elf +QCSDI_CBFS := $(CONFIG_CBFS_PREFIX)/qcsdi +$(QCSDI_CBFS)-file := $(QCSDI_FILE) +$(QCSDI_CBFS)-type := stage +$(QCSDI_CBFS)-compression := $(CBFS_COMPRESS_FLAG) +cbfs-files-y += $(QCSDI_CBFS) +endif + +################################################################################ QC_SEC_FILE := $(SC7280_BLOB)/qc_sec/qc_sec.mbn $(objcbfs)/bootblock.bin: $(objcbfs)/bootblock.raw.elf @util/qualcomm/createxbl.py --mbn_version 6 -f $(objcbfs)/bootblock.raw.elf \

103 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

1035

days inactive

1465

days old

coreboot-gerrit@coreboot.org

22 comments

5 participants

tags (0)

participants (5)

Julius Werner (Code Review)
mturney mturney (Code Review)
Ravi kumar (Code Review)
Ravi Kumar Bokka (Code Review)
Shelley Chen (Code Review)