Attention is currently required from: Ravi kumar.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50587 )
Change subject: sc7280: Reserve wlan & wpss dram memory regions
......................................................................
Patch Set 38:
(1 comment)
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/50587/comment/d9ce9a5b_f298f9e9
PS38, Line 15: 4
Why 4 and 5? I mean I think it doesn't hurt, but generally this index is intended to be sequential.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50587
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic98b5d08a0a7b3f772582bf85d94f901a7c53010
Gerrit-Change-Number: 50587
Gerrit-PatchSet: 38
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Tue, 01 Jun 2021 15:57:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment