HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC on none reliable macro ......................................................................
temporarily silent GCC on none reliable macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Also initialize 'reply.command' to avoid this error: src/northbridge/intel/ironlake/raminit.c: In function 'setup_heci_uma': src/northbridge/intel/ironlake/raminit.c:1805:11: error: 'reply.command' may be used uninitialized in this function [-Werror=maybe-uninitialized] 1805 | if (reply.command != (MKHI_SET_UMA | (1 << 7))) | ~~~~~^~~~~~~~ cc1: all warnings being treated as errors
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/northbridge/intel/ironlake/raminit.c 2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/1
diff --git a/Makefile.inc b/Makefile.inc index 86335d9..4e515c4 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -412,6 +412,12 @@ CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wdangling-else CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie + +# Disable 'overflow' waring for not reliable MCHBARx_AND_OR macro +ifeq ($(CONFIG_NORTHBRIDGE_INTEL_X4X)$(CONFIG_NORTHBRIDGE_INTEL_PINEVIEW)$(CONFIG_NORTHBRIDGE_INTEL_SANDYBRIDGE)$(CONFIG_NORTHBRIDGE_INTEL_IRONLAKE)$(CONFIG_NORTHBRIDGE_INTEL_HASWELL),y) +CFLAGS_common += -Wno-overflow +endif + ifeq ($(CONFIG_COMPILER_GCC),y) # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) diff --git a/src/northbridge/intel/ironlake/raminit.c b/src/northbridge/intel/ironlake/raminit.c index e85163f..12162ff 100644 --- a/src/northbridge/intel/ironlake/raminit.c +++ b/src/northbridge/intel/ironlake/raminit.c @@ -1775,7 +1775,7 @@ { struct uma_reply { u8 group_id; - u8 command; + u8 command = 0; u8 reserved; u8 result; u8 field2;
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#2).
Change subject: temporarily silent GCC on none reliable macro ......................................................................
temporarily silent GCC on none reliable macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Also initialize 'reply.command' to avoid this error: src/northbridge/intel/ironlake/raminit.c: In function 'setup_heci_uma': src/northbridge/intel/ironlake/raminit.c:1805:11: error: 'reply.command' may be used uninitialized in this function [-Werror=maybe-uninitialized] 1805 | if (reply.command != (MKHI_SET_UMA | (1 << 7))) | ~~~~~^~~~~~~~ cc1: all warnings being treated as errors
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile M Makefile.inc M src/northbridge/intel/ironlake/raminit.c M util/crossgcc/Makefile M util/crossgcc/Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/acpica-unix2-20200110_iasl.patch D util/crossgcc/patches/binutils-2.33.1_as-ipxe.patch D util/crossgcc/patches/binutils-2.33.1_mips-gold.patch D util/crossgcc/patches/binutils-2.33.1_no-bfd-doc.patch D util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_gnat.patch D util/crossgcc/patches/gcc-8.3.0_gnat_eh.patch D util/crossgcc/patches/gcc-8.3.0_libgcc.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch D util/crossgcc/patches/gdb-8.3.1_amd64.patch D util/crossgcc/patches/gdb-8.3.1_no-doc.patch D util/crossgcc/patches/gdb-8.3.1_pythonhome.patch D util/crossgcc/patches/gmp-6.1.2_freebsd-configure.patch D util/crossgcc/patches/make-4.2.1_0053-glob-Do-not-assume-glibc-glob-internals.patch D util/crossgcc/patches/make-4.2.1_0068-configure.ac-Support-GLIBC-glob-interface-version-2.patch D util/crossgcc/patches/make-4.2.1_alloca.patch D util/crossgcc/sum/Python-3.8.1.tar.xz.cksum D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum D util/crossgcc/sum/binutils-2.33.1.tar.xz.cksum D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum D util/crossgcc/sum/gdb-8.3.1.tar.xz.cksum D util/crossgcc/sum/gmp-6.1.2.tar.xz.cksum D util/crossgcc/sum/make-4.2.1.tar.bz2.cksum 30 files changed, 22 insertions(+), 21,936 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#3).
Change subject: temporarily silent GCC on none reliable macro ......................................................................
temporarily silent GCC on none reliable macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Also initialize 'reply.command' to avoid this error: src/northbridge/intel/ironlake/raminit.c: In function 'setup_heci_uma': src/northbridge/intel/ironlake/raminit.c:1805:11: error: 'reply.command' may be used uninitialized in this function [-Werror=maybe-uninitialized] 1805 | if (reply.command != (MKHI_SET_UMA | (1 << 7))) | ~~~~~^~~~~~~~ cc1: all warnings being treated as errors
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/northbridge/intel/ironlake/raminit.c 2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC on none reliable macro ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc@416 PS3, Line 416: waring warning
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc@416 PS3, Line 416: not reliable I'd say `previously unaffected` instead
https://review.coreboot.org/c/coreboot/+/42448/3/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/42448/3/src/northbridge/intel/ironl... PS3, Line 1805: // if (reply.command != (MKHI_SET_UMA | (1 << 7))) No, initialize `reply` instead. This is wrong.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC on none reliable macro ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42448/2/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/42448/2/src/northbridge/intel/ironl... PS2, Line 1778: :0; That is completely wrong.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#4).
Change subject: temporarily silent GCC on none reliable macro ......................................................................
temporarily silent GCC on none reliable macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Also initialize 'reply.command' to avoid this error: src/northbridge/intel/ironlake/raminit.c: In function 'setup_heci_uma': src/northbridge/intel/ironlake/raminit.c:1805:11: error: 'reply.command' may be used uninitialized in this function [-Werror=maybe-uninitialized] 1805 | if (reply.command != (MKHI_SET_UMA | (1 << 7))) | ~~~~~^~~~~~~~ cc1: all warnings being treated as errors
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/northbridge/intel/ironlake/raminit.c 2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/4
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#5).
Change subject: temporarily silent GCC on none reliable macro ......................................................................
temporarily silent GCC on none reliable macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC on none reliable macro ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc@416 PS3, Line 416: not reliable
I'd say `previously unaffected` instead
Done
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc@416 PS3, Line 416: waring
warning
Done
https://review.coreboot.org/c/coreboot/+/42448/2/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/42448/2/src/northbridge/intel/ironl... PS2, Line 1778: :0;
That is completely wrong.
Done
https://review.coreboot.org/c/coreboot/+/42448/3/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/42448/3/src/northbridge/intel/ironl... PS3, Line 1805: // if (reply.command != (MKHI_SET_UMA | (1 << 7)))
No, initialize `reply` instead. This is wrong.
Done
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#11).
Change subject: temporarily silent GCC on none reliable macro ......................................................................
temporarily silent GCC on none reliable macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/11
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#12).
Change subject: temporarily silent GCC on none reliable MCHBARx_AND_OR macros ......................................................................
temporarily silent GCC on none reliable MCHBARx_AND_OR macros
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/12
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#13).
Change subject: temporarily silent GCC on none reliable MCHBARx_AND_OR macros ......................................................................
temporarily silent GCC on none reliable MCHBARx_AND_OR macros
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/13
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#14).
Change subject: temporarily silent GCC on unreliable MCHBARx_AND_OR macros ......................................................................
temporarily silent GCC on unreliable MCHBARx_AND_OR macros
GCC-10 highlighted a unreliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/14
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#16).
Change subject: temporarily silent GCC on none reliable macro ......................................................................
temporarily silent GCC on none reliable macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/16
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC on none reliable macro ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42448/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42448/16//COMMIT_MSG@7 PS16, Line 7: temporarily silent GCC on none reliable macro It's the warning option, not the macro, that is unreliable.
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#17).
Change subject: temporarily silent GCC overflow warning on MCHBARx_AND_OR macro ......................................................................
temporarily silent GCC overflow warning on MCHBARx_AND_OR macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/17
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#18).
Change subject: temporarily silent GCC overflow warning on MCHBARx_AND_OR macro ......................................................................
temporarily silent GCC overflow warning on MCHBARx_AND_OR macro
GCC-10 highlighted a none reliable MCHBARx_AND_OR macro:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/18
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC overflow warning on MCHBARx_AND_OR macro ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42448/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42448/16//COMMIT_MSG@7 PS16, Line 7: temporarily silent GCC on none reliable macro
It's the warning option, not the macro, that is unreliable.
Done
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42448
to look at the new patch set (#19).
Change subject: temporarily silent GCC overflow warning on MCHBARx_AND_OR macro ......................................................................
temporarily silent GCC overflow warning on MCHBARx_AND_OR macro
GCC-10 highlighted a MCHBARx_AND_OR macros:
x4x: src/northbridge/intel/x4x/x4x.h:79:16: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*(volatile u8 *)((unsigned int)((int)i * 1024) + 4275126888) & -256 | 74' to '74' [-Werror=overflow] 79 | (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/x4x/raminit_ddr23.c:627:3: note: in expansion of macro 'MCHBAR8_AND_OR' 627 | MCHBAR8_AND_OR(0x400*i + 0x268, ~0xff, 0x4a); | ^~~~~~~~~~~~~~ src/northbridge/intel/x4x/raminit_ddr23.c: In function 'prog_rcomp': src/northbridge/intel/x4x/x4x.h:83:17: error: overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow] 83 | (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or)) | ^
and for pineview: src/northbridge/intel/pineview/raminit.c: In function 'sdram_timings': src/northbridge/intel/pineview/pineview.h:98:52: error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow] 98 | #define MCHBAR8_AND_OR(x, and, or) (MCHBAR8(x) = (MCHBAR8(x) & (and)) | (or)) | ^ src/northbridge/intel/pineview/raminit.c:793:2: note: in expansion of macro 'MCHBAR8_AND_OR' 793 | MCHBAR8_AND_OR(SHPAGECTRL, ~0xff, 0x40); | ^~~~~~~~~~~~~~
Change-Id: I07c1b3bd00de27c115994233086d32497b4c0925 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42448/19
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC overflow warning on MCHBARx_AND_OR macro ......................................................................
Patch Set 19: Code-Review+2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC overflow warning on MCHBARx_AND_OR macro ......................................................................
Abandoned
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC overflow warning on MCHBARx_AND_OR macro ......................................................................
Patch Set 20:
"overflow error" not a warning.
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)