Attention is currently required from: Lance Zhao, Konrad Adamczyk, Jakub Czapiga, Grzegorz Bernacki, Tim Van Patten, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74715 )
Change subject: acpi: Add missing cbfs_unmap()
......................................................................
Patch Set 3:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74715/comment/0509364d_db677699
PS2, Line 1934: cbfs_unmap(dsdt_file);
As long as you don't overflow your heap, there aren't any problems with this approach. […]
Your point about better documentation is incredibly valid ;) There are patches that come up randomly sometimes that are trying to "fix" mallocs() that don't free(), it would be better to have some authoritative place to point to saying this is our current strategy.
Maybe `free()` should be renamed to `maybe_free()` or `free_latest()` just as examples to help avoid this confusion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf7ba6842f42404ad8bb415f8e7fda10403cbe2e
Gerrit-Change-Number: 74715
Gerrit-PatchSet: 3
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 20:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment