Attention is currently required from: Angel Pons, Nico Huber, Patrick Rudolph, Paul Menzel, Vlado Cibic.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73693?usp=email )
Change subject: mb/asus/p8z77-m[_pro]: Properly configure early serial ......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
Devicetrees of these two differ: '-M' enables a UART A, '-M PRO' enables a UART B. […]
I looked at -M PRO's devicetree again. Its serial port setup is broken in other ways. As you said it enables UART B, places it at I/O port 0x2f8 like a second serial port should (but didn't match CONFIG_TTYS0_BASE) but didn't program an IRQ, and no superio programming to route any serial port signals out (which the code in question here should have done). And I don't see any other boards that enable UART B and only UART B.
It'll need a proper fix and a proper testing by someone with the hardware. So I'm going to split -M off into its own patch.
-
Keith Hui (Code Review)