Change in coreboot[master]: nb/intel/x4x: Prepare for x86_64 support - coreboot-gerrit

2 Jul 2021


      Attention is currently required from: Damien Zammit, Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56019 )
Change subject: nb/intel/x4x: Prepare for x86_64 support
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/northbridge/intel/x4x/dq_dqs.c:
https://review.coreboot.org/c/coreboot/+/56019/comment/a8ad094f_56906265 
PS1, Line 173: write32
You could use write32p (note the trailing `p`) but it probably won't be reproducible. Can be done in a follow-up.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56019
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id44eeb7660d0b521a326a5b981c04c16cf0a6f84
Gerrit-Change-Number: 56019
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Fri, 02 Jul 2021 08:17:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment