Change in coreboot[master]: resource_allocator_v4: Fix size of I/O hole at 0x3b0

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41737 )

Change subject: resource_allocator_v4: Fix size of I/O hole at 0x3b0
......................................................................

resource_allocator_v4: Fix size of I/O hole at 0x3b0

Addressing comment from CB:41443 that was received after the change
landed. memranges_create_hole() takes size as the last parameter. So,
the I/O hole created at 0x3b0 needs to set size as 0x3df - 0x3b0 + 1
as 0x3df is the upper limit of that hole.

Change-Id: I08fca283436924427e12c6c69edced7e51db42a9
Signed-off-by: Furquan Shaikh 
---
M src/device/resource_allocator_v4.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/41737/1

diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c
index ece7150..b65fc8b 100644
--- a/src/device/resource_allocator_v4.c
+++ b/src/device/resource_allocator_v4.c
@@ -330,7 +330,7 @@
    	 * Don't allow allocations in the VGA I/O range. PCI has special cases for
    	 * that.
    	 */
-		memranges_create_hole(ranges, 0x3b0, 0x3df);
+		memranges_create_hole(ranges, 0x3b0, 0x3df - 0x3b0 + 1);

/*
    	 * Resource allocator no longer supports the legacy behavior where I/O resource

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41737 )

Change subject: resource_allocator_v4: Fix size of I/O hole at 0x3b0
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41737 )

Change subject: resource_allocator_v4: Fix size of I/O hole at 0x3b0
......................................................................

Patch Set 1: Code-Review+2

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41737 )

Change subject: resource_allocator_v4: Fix size of I/O hole at 0x3b0
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41737 )

Change subject: resource_allocator_v4: Fix size of I/O hole at 0x3b0
......................................................................

resource_allocator_v4: Fix size of I/O hole at 0x3b0

Addressing comment from CB:41443 that was received after the change
landed. memranges_create_hole() takes size as the last parameter. So,
the I/O hole created at 0x3b0 needs to set size as 0x3df - 0x3b0 + 1
as 0x3df is the upper limit of that hole.

Change-Id: I08fca283436924427e12c6c69edced7e51db42a9
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41737
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
Reviewed-by: Angel Pons 
Reviewed-by: Aaron Durbin 
---
M src/device/resource_allocator_v4.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Aaron Durbin: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c
index ece7150..b65fc8b 100644
--- a/src/device/resource_allocator_v4.c
+++ b/src/device/resource_allocator_v4.c
@@ -330,7 +330,7 @@
    	 * Don't allow allocations in the VGA I/O range. PCI has special cases for
    	 * that.
    	 */
-		memranges_create_hole(ranges, 0x3b0, 0x3df);
+		memranges_create_hole(ranges, 0x3b0, 0x3df - 0x3b0 + 1);

/*
    	 * Resource allocator no longer supports the legacy behavior where I/O resource

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41737 )

Change subject: resource_allocator_v4: Fix size of I/O hole at 0x3b0
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4210
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4209
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4208
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4207

Please note: This test is under development and might not be accurate at all!