[S] Change in coreboot[main]: arch/x86/cpu_common: Add cpu_get_c_substate_support - coreboot-gerrit

30 Jun 2024


      Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/78224?usp=email )
Change subject: arch/x86/cpu_common: Add cpu_get_c_substate_support
......................................................................
Patch Set 3:
(1 comment)
File src/arch/x86/cpu_common.c:
https://review.coreboot.org/c/coreboot/+/78224/comment/79d9c1d0_a42208cf?usp... :
PS3, Line 200: 	    !(cpuid_ecx(5) & CPUID_FEATURE_MONITOR_MWAIT) || (state > 4))
Is this Intel-specific?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78224?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie57e87609ea5d6ec6f37154e8b84f1e9574aa4a9
Gerrit-Change-Number: 78224
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Comment-Date: Sun, 30 Jun 2024 13:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No