Change in coreboot[master]: payloads/LinuxBoot: make linux kernel build reproducible

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Alexander Couzens (Code Review)

13 Sep 2019 13 Sep '19

4:35 a.m.

Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35393 )

Change subject: payloads/LinuxBoot: make linux kernel build reproducible ......................................................................

payloads/LinuxBoot: make linux kernel build reproducible

Reproducible builds have to be independent from user, host, domain, time. Taken from OpenWrt (GPL2).

Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35393/1

diff --git a/payloads/external/LinuxBoot/targets/linux.mk b/payloads/external/LinuxBoot/targets/linux.mk index 8be0926..c676f68 100644 --- a/payloads/external/LinuxBoot/targets/linux.mk +++ b/payloads/external/LinuxBoot/targets/linux.mk @@ -30,7 +30,11 @@

OBJCOPY:=$(LINUXBOOT_CROSS_COMPILE)objcopy KERNEL_MAKE_FLAGS = \ - ARCH=$(ARCH-y) + ARCH=$(ARCH-y) \ + KBUILD_BUILD_USER="coreboot" \ + KBUILD_BUILD_HOST="reproducible" \ + KBUILD_BUILD_TIMESTAMP="$(shell perl -e 'print scalar gmtime($(SOURCE_DATE_EPOCH))')" \ + KBUILD_BUILD_VERSION="0"

ifeq ($(CONFIG_LINUXBOOT_KERNEL_CUSTOM),y) kernel_version:=$(CONFIG_LINUXBOOT_KERNEL_CUSTOM_VERSION)

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Alexander Couzens (Code Review)

13 Sep 13 Sep

5:58 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35393

to look at the new patch set (#2).

Change subject: payloads/LinuxBoot: make linux kernel build reproducible ......................................................................

payloads/LinuxBoot: make linux kernel build reproducible

Reproducible builds have to be independent from user, host, domain, time. Taken from OpenWrt (GPL2).

Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 Signed-off-by: Alexander Couzens lynxis@fe80.eu --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35393/2

Alexander Couzens (Code Review)

6:02 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35393

to look at the new patch set (#3).

Change subject: payloads/LinuxBoot: make linux kernel build reproducible ......................................................................

payloads/LinuxBoot: make linux kernel build reproducible

Reproducible builds have to be independent from user, host, domain, time. Taken from OpenWrt (GPL2).

Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 Signed-off-by: Alexander Couzens lynxis@fe80.eu --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35393/3

Alexander Couzens (Code Review)

6:03 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35393

to look at the new patch set (#4).

Change subject: payloads/LinuxBoot: make linux kernel build reproducible ......................................................................

payloads/LinuxBoot: make linux kernel build reproducible

Reproducible builds have to be independent from user, host, domain, time. Taken from OpenWrt (GPL2).

Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 Signed-off-by: Alexander Couzens lynxis@fe80.eu --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35393/4

Patrick Georgi (Code Review)

15 Sep 15 Sep

10:33 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35393 )

Change subject: payloads/LinuxBoot: make linux kernel build reproducible ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35393/4/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/targets/linux.mk:

https://review.coreboot.org/c/coreboot/+/35393/4/payloads/external/LinuxBoot... PS4, Line 36: SOURCE_DATE_EPOCH who sets this?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 Gerrit-Change-Number: 35393 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Sun, 15 Sep 2019 20:33:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Alexander Couzens (Code Review)

9 Mar 9 Mar

4:57 a.m.

Attention is currently required from: Stefan Reinauer, Christian Walter. Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35393 )

Change subject: payloads/LinuxBoot: make linux kernel build reproducible ......................................................................

Patch Set 5:

(1 comment)

File payloads/external/LinuxBoot/targets/linux.mk:

https://review.coreboot.org/c/coreboot/+/35393/comment/25b357e9_907ceb2b PS4, Line 36: SOURCE_DATE_EPOCH

...

who sets this?

I'm setting it now in a previous commit in the change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 Gerrit-Change-Number: 35393 Gerrit-PatchSet: 5 Gerrit-Owner: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Attention: Christian Walter christian.walter@9elements.com Gerrit-Comment-Date: Tue, 09 Mar 2021 03:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 Apr 6 Apr

6:35 p.m.

Attention is currently required from: Stefan Reinauer, Christian Walter, Alexander Couzens. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35393 )

Change subject: payloads/LinuxBoot: make linux kernel build reproducible ......................................................................

Patch Set 8: Code-Review+2

(1 comment)

Patchset:

PS8: needs the SOURCE_DATE_EPOCH thing solved, but otherwise LGTM

-- To view, visit https://review.coreboot.org/c/coreboot/+/35393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 Gerrit-Change-Number: 35393 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Attention: Christian Walter christian.walter@9elements.com Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Comment-Date: Tue, 06 Apr 2021 16:35:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9 Apr 9 Apr

8:10 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35393 )

Change subject: payloads/LinuxBoot: make linux kernel build reproducible ......................................................................

payloads/LinuxBoot: make linux kernel build reproducible

Reproducible builds have to be independent from user, host, domain, time. Taken from OpenWrt (GPL2).

Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 Signed-off-by: Alexander Couzens lynxis@fe80.eu Reviewed-on: https://review.coreboot.org/c/coreboot/+/35393 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 5 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/payloads/external/LinuxBoot/targets/linux.mk b/payloads/external/LinuxBoot/targets/linux.mk index 9906729..c6f4395 100644 --- a/payloads/external/LinuxBoot/targets/linux.mk +++ b/payloads/external/LinuxBoot/targets/linux.mk @@ -18,7 +18,11 @@

ifeq ($(CONFIG_LINUXBOOT_KERNEL_CUSTOM),y) kernel_version:=$(CONFIG_LINUXBOOT_KERNEL_CUSTOM_VERSION)

-- To view, visit https://review.coreboot.org/c/coreboot/+/35393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I420588acc66647051c08e4da6fbedc205cd62877 Gerrit-Change-Number: 35393 Gerrit-PatchSet: 10 Gerrit-Owner: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1324

days inactive

1898

days old

coreboot-gerrit@coreboot.org

7 comments

2 participants

tags (0)

participants (2)

Alexander Couzens (Code Review)
Patrick Georgi (Code Review)