Attention is currently required from: Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52628 )
Change subject: soc/intel/cannonlake: Clean up root port structs
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/cannonlake/chip.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118077):
https://review.coreboot.org/c/coreboot/+/52628/comment/3aed17c9_bca9fafa
PS4, Line 22: #if CONFIG(SOC_INTEL_CANNONLAKE_PCH_H)
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie256222ece35f1f607af1cc922aacf7c026432b9
Gerrit-Change-Number: 52628
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 29 Apr 2021 23:24:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment