Attention is currently required from: Angel Pons, Arthur Heymans, Julius Werner, Maximilian Brune, Nico Huber, Philipp Hug, Ron Minnich.
Hello Angel Pons, Arthur Heymans, Nico Huber, Philipp Hug, Ron Minnich, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81910?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed: Code-Review+1 by Angel Pons, Code-Review+1 by Arthur Heymans, Code-Review+2 by Nico Huber, Verified+1 by build bot (Jenkins)
Change subject: commonlib/bsd/lz4_wrapper.c: Fix misaligned access ......................................................................
commonlib/bsd/lz4_wrapper.c: Fix misaligned access
Currently the HiFive Unleashed produces the following exception: [DEBUG] Exception: Load address misaligned [DEBUG] Hart ID: 0 [DEBUG] Previous mode: machine [DEBUG] Bad instruction pc: 0x080010d0 [DEBUG] Bad address: 0x08026ab3 [DEBUG] Stored ra: 0x080010c8 [DEBUG] Stored sp: 0x08010cc8
The coreboot LZ4 decompression code does some misaligned access during decompression which the FU540 apparently does not support in SRAM.
Make the compiler generate code that adheres to natural alignment by fixing the LZ4_readLE16() function and creating LZ4_readLE32().
Signed-off-by: Maximilian Brune maximilian.brune@9elements.com Change-Id: Id165829bfd35be2bce2bbb019c208a304f627add --- M src/commonlib/bsd/lz4_wrapper.c 1 file changed, 21 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/81910/6