Attention is currently required from: Casper Chang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62703 )
Change subject: mb/google/brya/var/primus{4es}: add eMMC enable pin in ramstage
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62703/comment/67123942_b39ff6b1
PS5, Line 10: the
Start a new sentence?
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/62703/comment/339f0b6b_015c867d
PS7, Line 9: Currently the BayHub eMMC enable pin is using the default
: configuration from the baseboard, which leads to RTD3 not being
: able to control the GPIO when exiting and entering suspend. To fix
: this, program the GPIO in the ramstage GPIO table.
Next time please reflow for 72 characters per line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b6f164cc326bd368addb1e143ad2cbd449bb08d
Gerrit-Change-Number: 62703
Gerrit-PatchSet: 7
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Sun, 13 Mar 2022 19:18:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment