Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35321 )
Change subject: soc/fsp_broadwell_de: Add devhide functionality ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/include/soc/ubox.h:
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell... PS4, Line 44: static inline void iio_hide(uint8_t devno, uint8_t funcno) const
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell... PS4, Line 50: reg = pci_mmio_read_config32(ubox_dev, UBOX_DEVHIDE0 + (funcno * 4)); brackets not neccessary
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/southcluster.c:
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell... PS4, Line 257: int slot = PCI_SLOT(dev->path.pci.devfn); const
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell... PS4, Line 258: int func = PCI_FUNC(dev->path.pci.devfn); const