Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/79172?usp=email
to review the following change.
Change subject: Revert "nipperkin: Fix WLAN to GEN2 speed" & "Disable PSPP for WLAN" ......................................................................
Revert "nipperkin: Fix WLAN to GEN2 speed" & "Disable PSPP for WLAN"
Updated Linux FW works with PCI gen3 speed and PSPP.
This reverts commit 05c9a850fd21e060efdd54b5699aaf8f3c54d2a4 https://review.coreboot.org/c/coreboot/+/63593
and 76fddd9639250db8af486188a5ba39291006af8a https://review.coreboot.org/c/coreboot/+/63722
The changes are overlapped and are reverted together.
BUG=b:240426142
Change-Id: Id207076542edc8ea0cabc6e02e29856c2b6803c7 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/mainboard/google/guybrush/variants/nipperkin/variant.c 1 file changed, 1 insertion(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/79172/1
diff --git a/src/mainboard/google/guybrush/variants/nipperkin/variant.c b/src/mainboard/google/guybrush/variants/nipperkin/variant.c index bd6c48c..ff92e69 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/variant.c +++ b/src/mainboard/google/guybrush/variants/nipperkin/variant.c @@ -4,12 +4,5 @@
void variant_update_dxio_descriptors(fsp_dxio_descriptor *dxio_descriptors) { - /* Fix link speed to GEN2 - b/228830362 */ - dxio_descriptors[WLAN].link_speed_capability = GEN2; - dxio_descriptors[WLAN].port_params[0] = PP_PSPP_AC; - /* AC_DirectIndirect[11:8], AC_MaxPreferredSpeed[7:4], AC_MinPreferredSpeed[3:0] */ - dxio_descriptors[WLAN].port_params[1] = 0x122; - dxio_descriptors[WLAN].port_params[2] = PP_PSPP_DC; - /* DC_DirectIndirect[11:8], DC_MaxPreferredSpeed[7:4], DC_MinPreferredSpeed[3:0] */ - dxio_descriptors[WLAN].port_params[3] = 0x122; + /* Empty */ }