Attention is currently required from: Bao Zheng, Martin Roth, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78274?usp=email )
Change subject: amdfwtool: Set the table size for L1 separately ......................................................................
Patch Set 11:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/78274/comment/49272842_82e7ae81 : PS11, Line 655: if (cookie == PSP_COOKIE && cb_config->need_ish) : table_size = TABLE_ALIGNMENT; : else haven't traced the code, but from what i've seen, the actual bug seems to be that in integrate_psp_firmwares the new_ish_dir calls increase ctx->current to point to the end of the ish, but fill_dir_header which gets called after new_ish_dir expects ctx->current to point at the end of the psp directory table. saving the ctx->current before the new_ish_dir calls, using that for the fill_dir_header call and then restoring the ctx->current or something like that is probably a more maintainable fix