Attention is currently required from: Julius Werner, Rob Barnes, Yu-Ping Wu, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59083 )
Change subject: mb/google/guybrush: Add variant_tpm_gpio_table ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/guybrush/variants/nipperkin/gpio.c:
https://review.coreboot.org/c/coreboot/+/59083/comment/9f6e048c_2ad34528 PS1, Line 105: /* This table is used by nipperkin variant with board version >= 2. */ : static const struct soc_amd_gpio bid2_tpm_gpio_table[] = { : /* I2C3_SCL */ : PAD_NF(GPIO_19, I2C3_SCL, PULL_NONE), : /* I2C3_SDA */ : PAD_NF(GPIO_20, I2C3_SDA, PULL_NONE), : /* GSC_SOC_INT_L */ : PAD_INT(GPIO_85, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), : }; This is the same as the baseboard, can we remove it? ... Ah, we can't access it. nm
File src/security/vboot/vboot_common.h:
https://review.coreboot.org/c/coreboot/+/59083/comment/9c5a99ff_5d51c0a0 PS1, Line 47: verstage_mainboard_tpm_init Same as the previous one. Move to a cezanne specific header.