Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36553 )
Change subject: soc/intel/tigerlake/acpi: Copy acpi directory from icelake
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36553/1/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/36553/1/src/soc/intel/tigerlake/acp...
PS1, Line 85: LAnd (LGreaterEqual (Arg0, GPP_G0), LLessEqual (Arg0, GPP_A23)
Please use the new ASL syntax. […]
@Arthur, as mentioned earlier, we can take a CL separately where we migrate all ASL syntax to latest because i'm afraid there might be more instance and this is not just TGL changes. Do you agree ? i can raise a cb,org ticket to track this activity ?
https://review.coreboot.org/c/coreboot/+/36553/1/src/soc/intel/tigerlake/acp...
PS1, Line 87: Store (PID_GPIOCOM0, Local0)
Local0 = PID_GPIOCOM0
same as above ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If967cb5904f543ce21eb6e89421df0e5673d2238
Gerrit-Change-Number: 36553
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Nov 2019 08:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment