Julia Tsai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: DisablexHCIcompliance ......................................................................
DisablexHCIcompliance
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: If0bf68c8cf0a2a3b857395b6b82e46cc384ba65c --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/39874/1
diff --git a/src/mainboard/google/octopus/variants/lick/overridetree.cb b/src/mainboard/google/octopus/variants/lick/overridetree.cb index 3aa369e..6ad7ad2 100644 --- a/src/mainboard/google/octopus/variants/lick/overridetree.cb +++ b/src/mainboard/google/octopus/variants/lick/overridetree.cb @@ -112,4 +112,8 @@ end end # - I2C 6 end + + # Disable compliance mode + + register "DisableComplianceMode" = "1" end
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: DisablexHCIcompliance ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39874/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/lick/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39874/1/src/mainboard/google/octopu... PS1, Line 117: trailing whitespace
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39874
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants: Disable xHCI compliance mode ......................................................................
mb/google/octopus/variants: Disable xHCI compliance mode
Some usb devices exhibits signal loss which causes xHCI entering compliance mode. The resolution is to disable xHCI compliance mode.
BRANCH=octopus TEST=Verified usb operation successfully.
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: If0bf68c8cf0a2a3b857395b6b82e46cc384ba65c --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/39874/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants: Disable xHCI compliance mode ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39874/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39874/2//COMMIT_MSG@9 PS2, Line 9: exhibits no "s" at the end: exhibit
https://review.coreboot.org/c/coreboot/+/39874/2//COMMIT_MSG@9 PS2, Line 9: entering to enter
https://review.coreboot.org/c/coreboot/+/39874/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/lick/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39874/2/src/mainboard/google/octopu... PS2, Line 117: Please remove the tab on this line
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39874
to look at the new patch set (#3).
Change subject: mb/google/octopus/variants: Disable xHCI compliance mode ......................................................................
mb/google/octopus/variants: Disable xHCI compliance mode
Some usb devices exhibit signal loss which causes xHCI to enter compliance mode. The resolution is to disable xHCI compliance mode.
BRANCH=octopus TEST=Verified usb operation successfully.
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: If0bf68c8cf0a2a3b857395b6b82e46cc384ba65c --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/39874/3
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39874
to look at the new patch set (#4).
Change subject: DisablexHCIcompliance ......................................................................
DisablexHCIcompliance
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: If0bf68c8cf0a2a3b857395b6b82e46cc384ba65c --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/39874/4
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39874
to look at the new patch set (#5).
Change subject: mb/google/octopus/variants: Disable xHCI compliance mode ......................................................................
mb/google/octopus/variants: Disable xHCI compliance mode
Some usb devices exhibit signal loss which causes xHCI to enter compliance mode. The resolution is to disable xHCI compliance mode.
BRANCH=octopus TEST=Verified usb operation successfully.
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: If0bf68c8cf0a2a3b857395b6b82e46cc384ba65c --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/39874/5
Julia Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants: Disable xHCI compliance mode ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39874/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39874/2//COMMIT_MSG@9 PS2, Line 9: exhibits
no "s" at the end: exhibit
Done
https://review.coreboot.org/c/coreboot/+/39874/2//COMMIT_MSG@9 PS2, Line 9: entering
to enter
Done
https://review.coreboot.org/c/coreboot/+/39874/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/lick/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39874/2/src/mainboard/google/octopu... PS2, Line 117:
Please remove the tab on this line
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants: Disable xHCI compliance mode ......................................................................
Patch Set 5: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants: Disable xHCI compliance mode ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39874/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39874/5//COMMIT_MSG@9 PS5, Line 9: usb devices Please add at least the device model causing the problem, so people have a chance to verify it in the future.
Hash Hung has uploaded a new patch set (#6) to the change originally created by Julia Tsai. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants/lick: Disable xHCI compliance mode ......................................................................
mb/google/octopus/variants/lick: Disable xHCI compliance mode
Since the first LFPS timeout causes xHCI to enter compliance mode, the SS hub cannot be enumerated. The resolution is to disable xHCI compliance mode.
BRANCH=octopus TEST=Verified usb operation successfully.
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: If0bf68c8cf0a2a3b857395b6b82e46cc384ba65c --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/39874/6
Hash Hung has uploaded a new patch set (#7) to the change originally created by Julia Tsai. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants/lick: Disable xHCI compliance mode ......................................................................
mb/google/octopus/variants/lick: Disable xHCI compliance mode
Since the first LFPS timeout causes xHCI to enter compliance mode, the SS hub cannot be enumerated. The resolution is to disable xHCI compliance mode.
BRANCH=octopus BUG=b:153782196 TEST=Verified usb operation successfully.
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: If0bf68c8cf0a2a3b857395b6b82e46cc384ba65c --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/39874/7
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants/lick: Disable xHCI compliance mode ......................................................................
Patch Set 7:
We are waiting for SoC team to confirm the case here.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants/lick: Disable xHCI compliance mode ......................................................................
Patch Set 7: Code-Review+1
Soc team confirmed in related issue.
Hash Hung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants/lick: Disable xHCI compliance mode ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39874/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39874/5//COMMIT_MSG@9 PS5, Line 9: usb devices
Please add at least the device model causing the problem, so people have a chance to verify it in th […]
Hi Paul, We changed the description for what we found.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39874 )
Change subject: mb/google/octopus/variants/lick: Disable xHCI compliance mode ......................................................................
mb/google/octopus/variants/lick: Disable xHCI compliance mode
Since the first LFPS timeout causes xHCI to enter compliance mode, the SS hub cannot be enumerated. The resolution is to disable xHCI compliance mode.
BRANCH=octopus BUG=b:153782196 TEST=Verified usb operation successfully.
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: If0bf68c8cf0a2a3b857395b6b82e46cc384ba65c Reviewed-on: https://review.coreboot.org/c/coreboot/+/39874 Reviewed-by: Henry Sun henrysun@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Henry Sun: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/lick/overridetree.cb b/src/mainboard/google/octopus/variants/lick/overridetree.cb index 3aa369e..3ade354 100644 --- a/src/mainboard/google/octopus/variants/lick/overridetree.cb +++ b/src/mainboard/google/octopus/variants/lick/overridetree.cb @@ -112,4 +112,8 @@ end end # - I2C 6 end + + # Disable compliance mode + + register "DisableComplianceMode" = "1" end
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
Hash Hung (Code Review)
-
Henry Sun (Code Review)
-
Julia Tsai (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)