Change in coreboot[master]: nb/intel/sandybridge/raminit: Add ECC detection support - coreboot-gerrit

26 Jan 2020


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22214 )
Change subject: nb/intel/sandybridge/raminit: Add ECC detection support
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/22214/7/src/northbridge/intel/sandy... 
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/22214/7/src/northbridge/intel/sandy... 
PS7, Line 590: forced
...
Correct. If forced, it even takes precedence over ECC unsupported.
Right. I would update the comment to reflect that
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/22214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b7599746195cfa996a48320404a8dbe6820483a
Gerrit-Change-Number: 22214
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Kollasch jakllsch@kollasch.net
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 26 Jan 2020 22:22:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment