Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40121 )
Change subject: mb/google/glados: Use ACPI brightness controls ......................................................................
mb/google/glados: Use ACPI brightness controls
Enables ACPI backlight controls under Windows.
Test: build/boot chell variant, verify screen backlight controls available and functional under Windows 10.
Change-Id: Ida0102ac828254ae195528a8f1de078abed4a491 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/glados/devicetree.cb M src/mainboard/google/glados/dsdt.asl 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/40121/1
diff --git a/src/mainboard/google/glados/devicetree.cb b/src/mainboard/google/glados/devicetree.cb index e9c1cac..4e85e21 100644 --- a/src/mainboard/google/glados/devicetree.cb +++ b/src/mainboard/google/glados/devicetree.cb @@ -1,5 +1,8 @@ chip soc/intel/skylake
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gpu_pp_up_delay_ms" = "200" register "gpu_pp_down_delay_ms" = " 50" register "gpu_pp_cycle_delay_ms" = "500" diff --git a/src/mainboard/google/glados/dsdt.asl b/src/mainboard/google/glados/dsdt.asl index 879e888..7e3a1a2 100644 --- a/src/mainboard/google/glados/dsdt.asl +++ b/src/mainboard/google/glados/dsdt.asl @@ -35,6 +35,7 @@ { #include <soc/intel/skylake/acpi/systemagent.asl> #include <soc/intel/skylake/acpi/pch.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
// Dynamic Platform Thermal Framework
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40121 )
Change subject: mb/google/glados: Use ACPI brightness controls ......................................................................
Patch Set 1: Code-Review+2
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40121 )
Change subject: mb/google/glados: Use ACPI brightness controls ......................................................................
mb/google/glados: Use ACPI brightness controls
Enables ACPI backlight controls under Windows.
Test: build/boot chell variant, verify screen backlight controls available and functional under Windows 10.
Change-Id: Ida0102ac828254ae195528a8f1de078abed4a491 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40121 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/glados/devicetree.cb M src/mainboard/google/glados/dsdt.asl 2 files changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/glados/devicetree.cb b/src/mainboard/google/glados/devicetree.cb index e9c1cac..4e85e21 100644 --- a/src/mainboard/google/glados/devicetree.cb +++ b/src/mainboard/google/glados/devicetree.cb @@ -1,5 +1,8 @@ chip soc/intel/skylake
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gpu_pp_up_delay_ms" = "200" register "gpu_pp_down_delay_ms" = " 50" register "gpu_pp_cycle_delay_ms" = "500" diff --git a/src/mainboard/google/glados/dsdt.asl b/src/mainboard/google/glados/dsdt.asl index 879e888..7e3a1a2 100644 --- a/src/mainboard/google/glados/dsdt.asl +++ b/src/mainboard/google/glados/dsdt.asl @@ -35,6 +35,7 @@ { #include <soc/intel/skylake/acpi/systemagent.asl> #include <soc/intel/skylake/acpi/pch.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
// Dynamic Platform Thermal Framework
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)