Change in coreboot[master]: soc/intel/apollolake: Set sdcard card detect (CD) host owner...
Venkateswarlu V Vinjamuri has posted comments on this change. ( https://review.coreboot.org/18947 )
Change subject: soc/intel/apollolake: Set sdcard card detect (CD) host ownership ......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/#/c/18947/4//COMMIT_MSG Commit Message:
PS4, Line 16: CQ-DEPEND=448173
This CL was already merged.
Done
Line 17: BUG=chrome-os-partner:63070
This is the wrong bug attribution now. Please use the correct one.
Done
https://review.coreboot.org/#/c/18947/4/src/soc/intel/apollolake/acpi.c File src/soc/intel/apollolake/acpi.c:
Line 188: /* Assign sdcard cd address and community if GPIO is defined in devicetree */
80 cols.
Done
https://review.coreboot.org/#/c/18947/4/src/soc/intel/apollolake/acpi/gpioli... File src/soc/intel/apollolake/acpi/gpiolib.asl:
Line 67: /* Get Host ownership of GPIO community */
These functions are highly specific. They don't handle any GPIO in the comm
Done
Line 71: OperationRegion (PDW1, SystemMemory, Or ( Or (CONFIG_IOSF_BASE_ADDRESS,
80 cols
Done
Line 84: OperationRegion (PDW0, SystemMemory, Or ( Or (CONFIG_IOSF_BASE_ADDRESS,
80 cols
Done
Line 85: ShiftLeft(Arg0, 16)), 0x80), 4)
0x80 -> HOSTSW_OWN_REG_BASE
Done
https://review.coreboot.org/#/c/18947/4/src/soc/intel/apollolake/acpi/scs.as... File src/soc/intel/apollolake/acpi/scs.asl:
PS4, Line 127: HOSTSW_OWN_REG_GPIO_177
This shouldn't be pre-canned. This is the same issue I originally had with
Done
https://review.coreboot.org/#/c/18947/4/src/soc/intel/apollolake/gpio.c File src/soc/intel/apollolake/gpio.c:
Line 192: uint8_t gpio_get_pad_community(const uint16_t pad)
You aren't getting the community. You are asking for p2sb port id for the c
Done
-
Venkateswarlu V Vinjamuri (Code Review)